[
https://issues.apache.org/jira/browse/BCEL-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171864#comment-14171864
]
Maxim Degtyarev edited comment on BCEL-180 at 10/15/14 1:47 AM:
----------------------------------------------------------------
I disagree, passing class file format version to the constant pool constructor
smells bad.
At my point of view, such checks should not be responsibility of ConstantPool
class but instead take place in ClassParser
for ordinary class loading. Or, in case ClassParser not used, should be
performed explicitly in code that use BCEL library.
was (Author: maccimo):
I disagree, passing class file format version to the constructor smells bad.
At my point of view, such checks should not be responsibility of ConstantPool
class but instead take place in ClassParser
for ordinary class loading. Or, in case ClassParser not used, should be
performed explicitly in code that use BCEL library.
> Enable loading ConstantPool from a byte array
> ---------------------------------------------
>
> Key: BCEL-180
> URL: https://issues.apache.org/jira/browse/BCEL-180
> Project: Commons BCEL
> Issue Type: Improvement
> Reporter: Maxim Degtyarev
>
> In some cases such as JDI API we have the class constant pool content only in
> form of separate byte array. Currently there is no way to load constant pool
> from byte array.
> The proposed patch add new public constructor to the
> org.apache.bcel.classfile.ConstantPool that allow loading ConstantPool from
> byte array representation.
> GitHub pull request: https://github.com/apache/commons-bcel/pull/1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
