[ 
https://issues.apache.org/jira/browse/LANG-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246893#comment-14246893
 ] 

Sebb commented on LANG-1072:
----------------------------

URL: http://svn.apache.org/r1643038
Log:
LANG-1072 Duplicated "0x" check in createBigInteger in NumberUtils

Modified:
    commons/proper/lang/trunk/src/changes/changes.xml
    
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
    
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java

> Duplicated "0x" check in createBigInteger in NumberUtils
> --------------------------------------------------------
>
>                 Key: LANG-1072
>                 URL: https://issues.apache.org/jira/browse/LANG-1072
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>    Affects Versions: 3.3.2
>            Reporter: haiyang li
>            Priority: Minor
>             Fix For: 3.4
>
>
> I think there is typo in below line:
> {code:title= org.apache.commons.lang3.math.NumberUtils.java|borderStyle=solid}
>  if (str.startsWith("0x", pos) || str.startsWith("0x", pos)) { // hex
>             radix = 16;
>             pos += 2;
> }
> {code}
> The second "0x" should be "0X"
> {code:title= org.apache.commons.lang3.math.NumberUtils.java|borderStyle=solid}
>  if (str.startsWith("0x", pos) || str.startsWith("0X", pos)) { // hex
>             radix = 16;
>             pos += 2;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to