[ 
https://issues.apache.org/jira/browse/BCEL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emmanuel Bourg resolved BCEL-179.
---------------------------------
    Resolution: Won't Fix

I tried the 
[FastDataInputStream|http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FastDataInputStream.java?view=markup&pathrev=1637501]
 implementation evaluated by Tomcat but it broke the ClassParser:

{code}
org.apache.bcel.classfile.ClassFormatException: Invalid frame type found while 
parsing stack map table: -1
        at 
org.apache.bcel.classfile.StackMapTableEntry.<init>(StackMapTableEntry.java:95)
        at org.apache.bcel.classfile.StackMapTable.<init>(StackMapTable.java:73)
        at org.apache.bcel.classfile.Attribute.readAttribute(Attribute.java:216)
        at org.apache.bcel.classfile.Code.<init>(Code.java:95)
        at org.apache.bcel.classfile.Attribute.readAttribute(Attribute.java:175)
        at org.apache.bcel.classfile.FieldOrMethod.<init>(FieldOrMethod.java:79)
        at org.apache.bcel.classfile.Method.<init>(Method.java:81)
        at 
org.apache.bcel.classfile.ClassParser.readMethods(ClassParser.java:297)
        at org.apache.bcel.classfile.ClassParser.parse(ClassParser.java:155)
{code}

The class was removed from Tomcat because the performance gain was rather low. 
I don't think it's worth digging further this suggestion.

> improvement for "DataInputStream"
> ---------------------------------
>
>                 Key: BCEL-179
>                 URL: https://issues.apache.org/jira/browse/BCEL-179
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The following improvement issue was submitted for Tomcat's version of BCEL.
> It might well be useful here:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56953



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to