[
https://issues.apache.org/jira/browse/BCEL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben McCann updated BCEL-186:
----------------------------
Description:
I'd love to see 6.0 released.
Here was the last vote:
http://apache-commons.680414.n4.nabble.com/VOTE-Release-BCEL-6-0-based-on-RC3-td4667129.html
Konstantin Kolinko reported some issues with caching that blocked the release:
bq. I noted new methods that introduced caching into classfile.ConstantUtf8
class. BCEL_DONT_CACHE should at least have static setter, or a static setter
for a cache instance / a factory class. RELEASE-NOTES.txt describes this change
as [BCEL-163] Incorporate patch file from Findbugs which does not say much
about this change. Actually this change introduced caching for ConstantUtf8 and
ObjectType instances.
Emmanuel Bourg did some investigation and testing and reported back:
bq. If nobody object I'll remove this cache, the impact on the performance is
too important to enable it by default, and the static state smells like a quick
and dirty implementation. This feature could return as a pluggable cache if
someone wants to provide a patch.
garydgregory suggested adding a flush method to clear the cache in ObjectType
was:
I'd love to see 6.0 released.
Here was the last vote:
http://apache-commons.680414.n4.nabble.com/VOTE-Release-BCEL-6-0-based-on-RC3-td4667129.html
Konstantin Kolinko reported some issues with caching that blocked the release:
bq. I noted new methods that introduced caching into classfile.ConstantUtf8
class. BCEL_DONT_CACHE should at least have static setter, or a static setter
for a cache instance / a factory class. RELEASE-NOTES.txt describes this change
as [BCEL-163] Incorporate patch file from Findbugs which does not say much
about this change. Actually this change introduced caching for ConstantUtf8 and
ObjectType instances.
Emmanuel Bourg did some investigation and testing and reported back:
bq. If nobody object I'll remove this cache, the impact on the performance
is too important to enable it by default, and the static state smells
like a quick and dirty implementation. This feature could return as a
pluggable cache if someone wants to provide a patch.
garydgregory suggested adding a flush method to clear the cache in ObjectType
> Release 6.0
> -----------
>
> Key: BCEL-186
> URL: https://issues.apache.org/jira/browse/BCEL-186
> Project: Commons BCEL
> Issue Type: Task
> Affects Versions: 6.0
> Reporter: Ben McCann
> Priority: Blocker
> Fix For: 6.0
>
>
> I'd love to see 6.0 released.
> Here was the last vote:
> http://apache-commons.680414.n4.nabble.com/VOTE-Release-BCEL-6-0-based-on-RC3-td4667129.html
> Konstantin Kolinko reported some issues with caching that blocked the release:
> bq. I noted new methods that introduced caching into classfile.ConstantUtf8
> class. BCEL_DONT_CACHE should at least have static setter, or a static setter
> for a cache instance / a factory class. RELEASE-NOTES.txt describes this
> change as [BCEL-163] Incorporate patch file from Findbugs which does not say
> much about this change. Actually this change introduced caching for
> ConstantUtf8 and ObjectType instances.
> Emmanuel Bourg did some investigation and testing and reported back:
> bq. If nobody object I'll remove this cache, the impact on the performance is
> too important to enable it by default, and the static state smells like a
> quick and dirty implementation. This feature could return as a pluggable
> cache if someone wants to provide a patch.
> garydgregory suggested adding a flush method to clear the cache in ObjectType
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
