[ 
https://issues.apache.org/jira/browse/IMAGING-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263962#comment-14263962
 ] 

Benedikt Ritter commented on IMAGING-147:
-----------------------------------------

Hello Stephan,

I'm heaving trouble to apply your latest patch, since it is not based against 
the latest trunk. Can you update your patch?

I've already spotted a little copy/paste error: the JavaDoc for the key 
component of ColorCmyk BLACK is wrong.

The ColorHunterLab class still has very odd values: {{public static final 
ColorHunterLab RED = new ColorHunterLab(46.109, 78.962, 29.794);}} The same is 
true for ColorCieLuv: {{public static final ColorCieLuv RED = new 
ColorCieLuv(53.233, 175.053, 37.751);}}

Benedikt

> Color constants
> ---------------
>
>                 Key: IMAGING-147
>                 URL: https://issues.apache.org/jira/browse/IMAGING-147
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.color.*
>            Reporter: Benedikt Ritter
>              Labels: github
>             Fix For: Review Patch
>
>         Attachments: IMAGING-147_001.patch
>
>
> The Color classes should provide constants for useful colors like black, 
> white and maybe their base colors. For example ColorCmyk could provide 
> Constants for black, white, cyan, magenta and yellow ColorCmyk objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to