[
https://issues.apache.org/jira/browse/VFS-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267975#comment-14267975
]
Bernd Eckenfels commented on VFS-554:
-------------------------------------
Hmm, reading the source again it looks like I missunderstood the "inRefresh"
flag. It is not controlling that refresh() is not recursing, but it it
controlling when getChildren() creates a subtree. So it might be needed. I keep
this open until I am sure.
> Ftp and SFtp FileObjects should not overwrite refresh
> -----------------------------------------------------
>
> Key: VFS-554
> URL: https://issues.apache.org/jira/browse/VFS-554
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0, 2.1
> Reporter: Bernd Eckenfels
> Priority: Minor
>
> FTP and SFTP FileObejcts both implement their own refresh() method which does
> not more like setting some of the variables which are also nulled by
> doDetach() to null. I think the method can therefore completely be removed.
> This will remove the need for the inRefresh checks and for calling
> super.refresh().
> Those two are the only providers with their own (strange) overwrite. Sftp
> File Object also uses getType() this looks like a eager implementation, all
> other FileObjects dont do that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
