[ 
https://issues.apache.org/jira/browse/COLLECTIONS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290691#comment-14290691
 ] 

ASF GitHub Bot commented on COLLECTIONS-523:
--------------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/commons-collections/pull/2


> Removing unnecessary method
> ---------------------------
>
>                 Key: COLLECTIONS-523
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-523
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: Map
>    Affects Versions: 4.0
>            Reporter: Thiago Andrade
>            Priority: Minor
>             Fix For: 4.1
>
>
> I suggest remmove unnecessary method {{private V put(final K key, final V 
> value, final long now)}} from the class {{PassiveExpiringMap}} once the 
> {{final long now}} parameter was never used. I've addapted the code to work 
> properly.
> The param was confusing the logic of this method.
> Placeholder ticket for github PR 2: 
> https://github.com/apache/commons-collections/pull/2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to