[
https://issues.apache.org/jira/browse/BCEL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Roberts updated BCEL-209:
------------------------------
Attachment: invoke3.diff
> Bug fixes and improvements to InvokeDynamic and BootStrapMethods
> implementation
> -------------------------------------------------------------------------------
>
> Key: BCEL-209
> URL: https://issues.apache.org/jira/browse/BCEL-209
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Mark Roberts
> Attachments: invoke3.diff
>
>
> (Apologies in advance - this is a very large diff.)
> During the past year, both the Apache Commons BCEL team and our group here at
> the UW independently completed the support for InvokeDynamic . Some things
> we chose to do the same way, but there are a few items that are quite
> different. Trying not to be too biased, I believe our method is better. One
> of the larger differences is your decision to add the abstract class
> NameSignatureMethod between FieldOrMethod and CPInstruction and then have
> InvokeDynamic extend from that instead of from InvokeInstruction. To me this
> seems wrong. In addition to forcing InvokeDynamic to duplicate all the
> methods from InvokeInstruction and FieldOrMethod, it is awkward that it is
> the only form of the Invoke Instruction that doesn't derive from
> InvokeInstruction.
> This patch also includes several methods missing from the current
> implementation: alternative initializers, toString, and support for the
> Visitor paradigm.
> There are bug fixes to Constants.java and InstructionFinder.java as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
