[ 
https://issues.apache.org/jira/browse/IMAGING-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310641#comment-14310641
 ] 

Michael Groß commented on IMAGING-163:
--------------------------------------

Also does org.apache.commons.imaging.formats.ico.IcoImageParser::getXmpXml

This is done to implement the named method in abstract class 
org.apache.commons.imaging.ImageParser. 

Either, the implementation returning null is the default implementation in case 
of it isn't possible to return an XMP XML string: Then we can implement this in 
the abstract class ImageParser.

Or, we need a real implementation here.


> DcxImageParser.getXmpXml() always returns null
> ----------------------------------------------
>
>                 Key: IMAGING-163
>                 URL: https://issues.apache.org/jira/browse/IMAGING-163
>             Project: Commons Imaging
>          Issue Type: Improvement
>            Reporter: Michael Groß
>             Fix For: Patch Needed
>
>
> Affects PCX format - can't spot this format in "Components" field.
> org.apache.commons.imaging.formats.dcx.DcxImageParser.getXmpXml() always 
> returns null
> {noformat}
> /**
>      * Extracts embedded XML metadata as XML string.
>      * <p>
>      * 
>      * @param byteSource
>      *            File containing image data.
>      * @param params
>      *            Map of optional parameters, defined in ImagingConstants.
>      * @return Xmp Xml as String, if present. Otherwise, returns null.
>      * @throws org.apache.commons.imaging.ImageReadException
>      * @throws java.io.IOException
>      */
>     @Override
>     public String getXmpXml(final ByteSource byteSource, final 
> ImagingParameters params)
>             throws ImageReadException, IOException {
>         return null;
>     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to