[
https://issues.apache.org/jira/browse/COMPRESS-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved COMPRESS-302.
---------------------------
Resolution: Fixed
Fix Version/s: 1.10
Used a different method to minimise code changes - the original field is now
set in the constructor.
URL: http://svn.apache.org/r1660005
Log:
COMPRESS-302 Restore immutability/thread-safety to ArchiveStreamFactory.
Modified:
commons/proper/compress/trunk/src/changes/changes.xml
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java
> Retore immutability/thread-safety to ArchiveStreamFactory
> ---------------------------------------------------------
>
> Key: COMPRESS-302
> URL: https://issues.apache.org/jira/browse/COMPRESS-302
> Project: Commons Compress
> Issue Type: Bug
> Affects Versions: 1.9
> Reporter: Sebb
> Fix For: 1.10
>
> Attachments: COMPRESS-302.patch
>
>
> COMPRESS-180 added support for encoding.
> Unfortunately this was done in a way that broke immutability.
> Also the factory is no longer thread-safe as the encoding field is not
> synch/volatile.
> Consider whether to restore immutability, e.g. by adding a constuctor which
> takes the encoding setting. The setEntryEncoding method could be deprecated
> intitially and eventually dropped.
> One way to support immutability now would be to add a second final encoding
> field which is set by a new ctor. See patch to follow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
