[
https://issues.apache.org/jira/browse/BCEL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327207#comment-14327207
]
Emmanuel Bourg commented on BCEL-210:
-------------------------------------
- The NPE in {{LineNumberGen}} looks fine.
- The call to {{printStackTrace}} in {{SyntheticRepository}} isn't necessary
since the exception thrown bellow is chained with the IOException.
- {{System.err}} in {{Pass1Verifier}} isn't a good idea, we tend to avoid such
calls in our libraries. Using a logger is better, or here simply calling
{{addMessage()}}.
> Improve error handling
> ----------------------
>
> Key: BCEL-210
> URL: https://issues.apache.org/jira/browse/BCEL-210
> Project: Commons BCEL
> Issue Type: Improvement
> Reporter: Mark Roberts
> Priority: Minor
> Attachments: errors.diff
>
>
> Adds a null pointer check and a couple of printStackTrace() on fatal errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
