[
https://issues.apache.org/jira/browse/LANG-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375669#comment-14375669
]
ASF GitHub Bot commented on LANG-1091:
--------------------------------------
GitHub user CodingFabian opened a pull request:
https://github.com/apache/commons-lang/pull/58
LANG-1091 fixes shutdown of ExecutorPools used in Tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CodingFabian/commons-lang LANG-1091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 0cd7fda27649a20d96359257506302d9a950e035
Author: Fabian Lange <[email protected]>
Date: 2015-03-23T10:15:41Z
LANG-1091 fixes shutdown of ExecutorPools used in Tests.
----
> Shutdown thread pools in test cases
> -----------------------------------
>
> Key: LANG-1091
> URL: https://issues.apache.org/jira/browse/LANG-1091
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*, lang.concurrent.*
> Affects Versions: 3.3.2
> Environment: Linux, JDK 7
> Reporter: Jesper Öqvist
> Fix For: Patch Needed, 3.4
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The tests, in for example
> org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest, create thread
> pools which are not shut down properly, leading to idle worker threads that
> can prevent the JVM from shutting down properly.
> Suggested fix: shutdown() on the thread pool where a call to shutdown or
> shutdownNow is missing.
> Affected classes (these were the ones I could find easily, I may have missed
> some):
> * org.apache.commons.lang3.builder.ReflectionToStringStyleConcurrencyTest
> * org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest
> * org.apache.commons.lang3.concurrent.CallableBackgroundInitializerTest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
