[
https://issues.apache.org/jira/browse/LANG-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved LANG-1091.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: Patch Needed)
Assignee: Benedikt Ritter
{code}
$ svn ci -m "LANG-1091: Shutdown thread pools in test cases. This fixes #58
from github. Thanks to Fabian Lange."
Sending src/changes/changes.xml
Sending
src/test/java/org/apache/commons/lang3/builder/ReflectionToStringBuilderConcurrencyTest.java
Sending
src/test/java/org/apache/commons/lang3/builder/ToStringStyleConcurrencyTest.java
Sending
src/test/java/org/apache/commons/lang3/concurrent/BackgroundInitializerTest.java
Sending
src/test/java/org/apache/commons/lang3/concurrent/CallableBackgroundInitializerTest.java
Sending
src/test/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializerTest.java
Sending
src/test/java/org/apache/commons/lang3/time/FastDateFormatTest.java
Transmitting file data .......
Committed revision 1669310.
{code}
Thank you!
> Shutdown thread pools in test cases
> -----------------------------------
>
> Key: LANG-1091
> URL: https://issues.apache.org/jira/browse/LANG-1091
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*, lang.concurrent.*
> Affects Versions: 3.3.2
> Environment: Linux, JDK 7
> Reporter: Jesper Öqvist
> Assignee: Benedikt Ritter
> Fix For: 3.4
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The tests, in for example
> org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest, create thread
> pools which are not shut down properly, leading to idle worker threads that
> can prevent the JVM from shutting down properly.
> Suggested fix: shutdown() on the thread pool where a call to shutdown or
> shutdownNow is missing.
> Affected classes (these were the ones I could find easily, I may have missed
> some):
> * org.apache.commons.lang3.builder.ReflectionToStringStyleConcurrencyTest
> * org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest
> * org.apache.commons.lang3.concurrent.CallableBackgroundInitializerTest
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
