[
https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514829#comment-14514829
]
ASF GitHub Bot commented on LANG-701:
-------------------------------------
GitHub user jamessawle reopened a pull request:
https://github.com/apache/commons-lang/pull/38
LANG-701 Added new joinWith method to support varargs
...rom previous join methods, but have added ExpectedException rule to
allow for better exception handling in tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rightmove/commons-lang LANG-701
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit fad36aec29ce9eae5667ecc13369b986b3d8c82d
Author: James Sawle <[email protected]>
Date: 2014-11-17T18:15:14Z
LANG-701 Added new joinWith method to support varargs. Have used logic from
previous join methods, but have added ExpectedException rule to allow for
better exception handling in tests
commit 6f13931c0581a766d788d94ce529b4e64f63cef2
Author: James Sawle <[email protected]>
Date: 2014-11-18T11:11:56Z
LANG-701 Made changes based upon comments from pull request
commit 144e742d1428c436facba2611d49f5af272f9aa2
Author: James Sawle <[email protected]>
Date: 2014-12-15T12:23:40Z
LANG-701 Made changes suggested in JIRA comment. Added extra Javadoc with
examples, and handle nulls in the same way as 'join(Iterable, String)'
commit 9520af68f88bccd6f9abe8098b518f44a70764fb
Author: jamessawle <[email protected]>
Date: 2015-04-09T08:52:18Z
LANG-701 - Remove Objects.toString and ExpectedException from code
commit 24385a5313d92da95b92f72881facb9c757be138
Author: jamessawle <[email protected]>
Date: 2015-04-09T08:53:52Z
LANG-701 - Remove Objects.toString and ExpectedException from code
commit a9fac9b577dd4c7d3f21d05ef679937a9b741c4d
Author: jamessawle <[email protected]>
Date: 2015-04-09T08:59:07Z
Merge branch 'trunk' into LANG-701
commit 21b14a2a353a5ac0fb37d06eb5898d19e001eacd
Author: jamessawle <[email protected]>
Date: 2015-04-15T12:40:46Z
LANG-701 - Fixed issue where null value in varargs would cause null pointer
exception
commit 3506be5b26fcf5723dcc80c77792f2313fc40a76
Author: jamessawle <[email protected]>
Date: 2015-04-15T12:43:40Z
Merge remote-tracking branch 'remotes/upstream/trunk' into LANG-701
commit c5f22fc411a531b235d9b3ec134cf739d9c309d4
Author: jamessawle <[email protected]>
Date: 2015-04-23T11:50:56Z
LANG-701 - Fix issue with Idea auto-formatting code
commit 853da6a74222928745ad2e30573aad6dc21f5cfc
Author: jamessawle <[email protected]>
Date: 2015-04-23T11:59:49Z
LANG-701 - Fix issue with using tabs instead of spaces
----
> StringUtils join with var args
> ------------------------------
>
> Key: LANG-701
> URL: https://issues.apache.org/jira/browse/LANG-701
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
> Reporter: Gabriele Kahlout
> Priority: Minor
> Fix For: Review Patch
>
> Attachments: VarArgJoinTest.java
>
>
> {code:java}
> final String apple = "apple";
> final String banana = "banana";
> final String orange = "orange";
> final String expected = apple + SPACE + banana + SPACE + orange;
> final String actual = join(SPACE, apple, banana, orange);
> final int expLength = expected.length();
> final int actLength = actual.length();
> assertEquals(expLength, actLength);
> assertEquals(expected, actual);
> {code}
> I missed the functionality of joining strings with the space separator in one
> line. BTW, why space ' ' not a constant field anywhere?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
