[ 
https://issues.apache.org/jira/browse/LANG-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525807#comment-14525807
 ] 

ASF GitHub Bot commented on LANG-1127:
--------------------------------------

GitHub user britter opened a pull request:

    https://github.com/apache/commons-lang/pull/76

    LANG-1127: Use JUnit rules to set and reset the default Locale and TimeZone

    Alternative proposal to fix 
[LANG-1127](https://issues.apache.org/jira/browse/LANG-1127) using JUnit 
TestRules.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/commons-lang LANG-1127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit abfcf0a8cfb40cd30c83d30923bea6d412cc5a22
Author: Benedikt Ritter <[email protected]>
Date:   2015-05-03T12:20:03Z

    LANG-1127: Use JUnit rules to set and reset the default Locale and TimeZone.

----


> Create a base test for the time package, which sets and resets default 
> Locales and TimeZones
> --------------------------------------------------------------------------------------------
>
>                 Key: LANG-1127
>                 URL: https://issues.apache.org/jira/browse/LANG-1127
>             Project: Commons Lang
>          Issue Type: Test
>          Components: lang.time.*
>            Reporter: Benedikt Ritter
>            Assignee: Charles Honton
>             Fix For: Patch Needed
>
>
> We have a lot of problems due to Locale dependent tests. I propose to create 
> a base test class with a setup and teardown method which set and reset 
> default locale and time zone. All other tests should inherit from this base 
> test class so that they don't have to fiddle around with default settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to