[
https://issues.apache.org/jira/browse/LANG-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557370#comment-14557370
]
ASF GitHub Bot commented on LANG-779:
-------------------------------------
GitHub user dstewart opened a pull request:
https://github.com/apache/commons-lang/pull/90
LANG-779 Use StringBuilder instead of StringBuffer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dstewart/commons-lang LANG-779
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 8a6b5a6023aed533afef1d2f61c63feac4f9b46e
Author: Daniel Stewart <[email protected]>
Date: 2015-05-23T14:46:03Z
LANG-779 Use StringBuilder instead of StringBuffer
----
> Provide a StrBuilder-based or StringBuilder-based ToStringBuilder
> -----------------------------------------------------------------
>
> Key: LANG-779
> URL: https://issues.apache.org/jira/browse/LANG-779
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
> Affects Versions: 3.1
> Reporter: Simon Dierl
> Priority: Minor
> Fix For: Patch Needed
>
>
> At the moment, ToStringBuilder internally uses a StringBuffer to create the
> output String. StringBuffer, as opposed to StringBuilder and StrBuilder, is
> synchronized. Since ToStringBuilder will almost never leave the
> toString()-method, the synchronization only adds overhead.
> Since the ToStringBuilder API never suggests that ToStringBuilder is
> thread-safe, either the current implementation could be changed to use
> Str[ing]Builder or an alternative implementation could be provided.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
