[
https://issues.apache.org/jira/browse/VALIDATOR-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566128#comment-14566128
]
Ayoma Gayan Wijethunga commented on VALIDATOR-367:
--------------------------------------------------
Thank you so much for your valuable comment and guidelines.
mvn test completes with :
Tests run: 446, Failures: 0, Errors: 0, Skipped: 0
and 'mvn site' and 'mvn package' completes without any error.
Actually, as I am not adding any new methods or logic, but updating only the
static TLD list to latest. Therefore, no change was done in unit tests. I
believe no change is necessary in unit tests as the test coverage was not
affected by the change (verified with Cobertura).
Thank you again for your support and guidelines provided. It surely was helpful
as a fresh contributor towards Apache.
> TLD list of DomainValidator is out of date (159 of 947 not available)
> ---------------------------------------------------------------------
>
> Key: VALIDATOR-367
> URL: https://issues.apache.org/jira/browse/VALIDATOR-367
> Project: Commons Validator
> Issue Type: Bug
> Components: Routines
> Affects Versions: 1.4.1 Release
> Reporter: Ayoma Gayan Wijethunga
> Attachments: DomainValidator.java.patch
>
>
> TLD list of DomainValidator is out of date.
> 159 new TLDs out of 947 are not available in DomainValidator.
> Until such time as a better method is implemented, adding new entries from
> http://data.iana.org/TLD/tlds-alpha-by-domain.txt
> Main reason for creating this issue is that unavailability of relevant TLDs
> result in 16% failure in a local parameterised unit test, which tests against
> email addressed from all possible TLDs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
