[
https://issues.apache.org/jira/browse/DBCP-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568862#comment-14568862
]
Michael Mikhulya commented on DBCP-436:
---------------------------------------
quote from HikariCP issue tracker:
{quote}
Part of the challenge is tracking when a transaction is or is not active. It
requires keeping a dirty flag that is reset by commit() but can be dirtied via
a multitude of paths.
{quote}
> Avoid executing ROLLBACK when transaction is not active
> -------------------------------------------------------
>
> Key: DBCP-436
> URL: https://issues.apache.org/jira/browse/DBCP-436
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: Michael Mikhulya
> Labels: performance
>
> {{rollbackOnReturn}} terminates the transaction by calling {{rollback}} on
> the connection as it is returned to the pool.
> It hurts performance.
> I suggest to don't call {{rollback}} if transaction is not active.
> Such improvement is done in HikariCP:
> https://github.com/brettwooldridge/HikariCP/issues/177
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
