[
https://issues.apache.org/jira/browse/LANG-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583141#comment-14583141
]
ASF GitHub Bot commented on LANG-1147:
--------------------------------------
GitHub user rikles opened a pull request:
https://github.com/apache/commons-lang/pull/97
LANG-1147 : Fix EnumUtils *BitVector issue with more than 32 values Enums
In `EnumUtils` all _BitVector_ related methods fail in handling Enum with
more than 32 values.
This is due to a implicit `int` -> `long` conversion in generating the Enum
value `long` mask.
```java
// Bad code : here `1` is an `int` value so the `<<` operation is done into
an `int` context and then, the result is converted to a `long` value
long mask = 1 << 32; // -> mask = 1 and not 4294967296 (0x100000000)
// Good code : here `1L` is a `long` value so the `<<` operation is done
into an `long` context
long mask = 1L << 32; // -> mask = 4294967296 (0x100000000)
```
I fixed this and add some tests into `EnumUtilsTest` with a 64 values Enum.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rikles/commons-lang fix-LANG-1147
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 1c9e5139f2b515f8741fbcb9c9b0f398d22d73ca
Author: Loic Guibert <[email protected]>
Date: 2015-06-12T08:19:37Z
LANG-1147 : Fix EnumUtils *BitVector issue with more than 32 values Enums
----
> EnumUtils *BitVector issue with more than 32 values Enum
> --------------------------------------------------------
>
> Key: LANG-1147
> URL: https://issues.apache.org/jira/browse/LANG-1147
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Affects Versions: 3.4
> Reporter: Loic Guibert
> Priority: Critical
>
> In *EnumUtils* all _BitVector_ related methods fail in handling Enums with
> more than 32 values.
> This is due to a implicit _int_ -> _long_ conversion in generating the Enum
> value _long_ mask.
> *Bad code :* here *1* is an _int_ value so the *<<* operation is done into an
> _int_ context and then, the result is converted to a _long_ value
> {code}
> long mask = 1 << 32; // -> mask = 1 and not 4294967296 (0x100000000)
> {code}
> *Good code :* here *1L* is a _long_ value so the *<<* operation is done into
> an _long_ context
> {code}
> long mask = 1L << 32; // -> mask = 4294967296 (0x100000000)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
