[ 
https://issues.apache.org/jira/browse/CSV-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589762#comment-14589762
 ] 

Michael Newcomb commented on CSV-152:
-------------------------------------

If it had the format object, it could do the above. Otherwise, it would have to:

{code}
public boolean isSet(final String name)
{
  return isMapped(name) &&
         mapping.get(name) < values.length &&
         nullString != null ? values[mapping.get(name)] != null : 
!values[mapping.get(name)].isEmpty();
}
{code}


> CSVRecord.isSet() does not check if value is not null
> -----------------------------------------------------
>
>                 Key: CSV-152
>                 URL: https://issues.apache.org/jira/browse/CSV-152
>             Project: Commons CSV
>          Issue Type: Bug
>            Reporter: Michael Newcomb
>
> Consider:
> public boolean isSet(final String name)
> {
>   return isMapped(name) && mapping.get(name).intValue() < values.length;
> }
> The docs say 'and has a value', however, it does not check if 
> values[mapping.get(name)] is null.
> Propose:
> public boolean isSet(final String name)
> {
>   return isMapped(name) && mapping.get(name) < values.length && 
> values[mapping.get(name)] != null;
> }
> Perhaps a new method 'hasValue' if the above is not desirable?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to