[jira] [Commented] (LANG-1151) Performance improvements for NumberUtils.isParsable

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/LANG-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595820#comment-14595820
 ] 

ASF GitHub Bot commented on LANG-1151:
--------------------------------------

GitHub user juanpablo-santos opened a pull request:

    https://github.com/apache/commons-lang/pull/99

    fix LANG-1151

    * ~2.5x performance increase wrt 3.4 version
    * added a couple checks more to unit tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/juanpablo-santos/commons-lang LANG-1151

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit cdfedf5fc8abdae7c09b85edc26602a0ce32f238
Author: Juan Pablo Santos Rodríguez <juanpablo.san...@gmail.com>
Date:   2015-06-22T11:53:06Z

    fix LANG-1151, ~2.5x performance increase wrt 3.4 version; added a couple 
checks more to unit tests

----


> Performance improvements for NumberUtils.isParsable
> ---------------------------------------------------
>
>                 Key: LANG-1151
>                 URL: https://issues.apache.org/jira/browse/LANG-1151
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.math.*
>    Affects Versions: 3.4
>            Reporter: Juan Pablo Santos Rodríguez
>
> NumberUtils.isParsable contains String comparisons + some String replacing, 
> which could be improved in terms of performance. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)