[
https://issues.apache.org/jira/browse/IO-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Rosenvold closed IO-448.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.5
Assignee: Kristian Rosenvold
> FileUtils.waitFor(...) swallows thread interrupted status
> ---------------------------------------------------------
>
> Key: IO-448
> URL: https://issues.apache.org/jira/browse/IO-448
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.4
> Reporter: Björn Buchner
> Assignee: Kristian Rosenvold
> Priority: Minor
> Fix For: 2.5
>
>
> The method waits for a file to appear for a given amount of time. To do so it
> calls Thread.sleep several times. If the thread is interrupted, the interrupt
> will be ignored by catching the ThreadInterrupted exception and waiting
> further.
> Catching the ThreadInterrupted exception automatically clears the thread's
> interrupted flag. Consequently the calling method has no chance to detect
> whether the thread was interrupted. A possible solution is to restore the
> interrupted status before returning - something like this:
> {code}
> public static boolean waitFor(File file, int seconds) {
> int timeout = 0;
> int tick = 0;
> boolean wasInterrupted = false;
> try {
> while (!file.exists()) {
> // ...
> try {
> Thread.sleep(100);
> } catch (InterruptedException ignore) {
> wasInterrupted = true;
> } catch (Exception ex) {
> break;
> }
> }
> return true;
> } finally {
> if (wasInterrupted) {
> Thread.currentThread.interrupt();
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
