[
https://issues.apache.org/jira/browse/BCEL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693680#comment-14693680
]
Sebb commented on BCEL-239:
---------------------------
URL: http://svn.apache.org/r1695546
Log:
BCEL-239 Interfaces should not be used to define constants
Convert InstructionConstants to a class
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConstants.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/PUSH.java
> Interfaces should not be used to define constants
> -------------------------------------------------
>
> Key: BCEL-239
> URL: https://issues.apache.org/jira/browse/BCEL-239
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Charles Honton
> Fix For: 6.0
>
>
> Interfaces should not be used to define constants.
> This is often done as a way to save typing the name of a class that defines
> the constants. However using an interface pollutes any implementing classes
> with all the constant names, even if they are not used.
> This issue applies to
> Constants
> ExceptionConstants
> InstructionConstants
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
