[
https://issues.apache.org/jira/browse/BCEL-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693945#comment-14693945
]
Sebb commented on BCEL-237:
---------------------------
Fixed InstructionConstants:
URL: http://svn.apache.org/r1695590
Log:
BCEL-237 non-empty final arrays should be private as they are mutable
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/Instruction.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConstants.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/PUSH.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/BCELFactory.java
> non-empty final arrays should be private as they are mutable
> ------------------------------------------------------------
>
> Key: BCEL-237
> URL: https://issues.apache.org/jira/browse/BCEL-237
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Charles Honton
> Fix For: 6.0
>
>
> Final array elements are not themselves final.
> So any final arrays should always be private, otherwise external code can
> corrupt the entries accidentally or deliberately.
> Either the array can be accessed through a getter that clones the contents,
> or the entries can be accessed through a getter that returns a single entry.
> This issue affects:
> Constants.class:
> CONSTANT_NAMES
> ACCESS_NAMES
> INTERFACES_IMPLEMENTED_BY_ARRAYS
> TYPE_NAMES
> CLASS_TYPE_NAMES
> SHORT_TYPE_NAMES
> NO_OF_OPERANDS
> TYPE_OF_OPERANDS
> OPCODE_NAMES
> CONSUME_STACK
> PRODUCE_STACK
> ATTRIBUTE_NAMES
> ITEM_NAMES
> METHODHANDLE_NAMES
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
