[
https://issues.apache.org/jira/browse/MATH-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704696#comment-14704696
]
Gilles commented on MATH-1259:
------------------------------
The concept was of a "counter" rather than an "incrementor"; so the name is a
bit misleading.
I can see that it could become an incrementor (where one would specify initial
and final values, rather than count number).
But please raise this issue on the "dev" ML to get more opinions on whether
this change is needed (preferably with a practical use-case), or whether it
would suffice to forbid negative counts (by throwing an exception).
> Negative max in class Incrementor
> ---------------------------------
>
> Key: MATH-1259
> URL: https://issues.apache.org/jira/browse/MATH-1259
> Project: Commons Math
> Issue Type: Bug
> Reporter: Gunel Jahangirova
> Priority: Minor
>
> In class Incrementor in the org.apache.commons.math4.util package it is
> possible to pass a negative number for the max variable. Given that the count
> variable is initialised to 0 by default, it means that canIncrement() method
> will always return false.
> I wonder whether it is an acceptable behaviour, given that documentation says
> that Incrementor is a utility that increments a counter until a maximum is
> reached. And in the case of negative max this maximum is not reachable at
> all.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
