[
https://issues.apache.org/jira/browse/CONFIGURATION-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946667#comment-14946667
]
Maarten Boekhold commented on CONFIGURATION-613:
------------------------------------------------
I was thinking about something like (pseudo-code):
{code}
public class MapConfiguration {
...
public Object getProperty(String key) {
Object value = map.get(key);
if ((value instanceof String) &&
!((String)value).contains(getListDelimiter())))
{
return value;
}
else if ((value instanceof String) && (!isDelimiterParsingDisabled()))
{
return PropertyConverter.split((String)value, getListDelimiter(),
!isTrimmingDisabled());
}
else
{
return value;
}
}
}
public class PropertyConverter {
...
public static List<String> split(String s, char delimiter, boolean trim) {
...
// replace occurrences of "if (trim) { t = t.trim(); }" with:
if (trim) {
if (list.size() == 0) {
// for first token, do not strip whitespace. Any whitespace
that is here
// was left there intentionally by java.util.Properties.load()
t = StringUtils.stripEnd(t, null);
} else {
t = s.trim();
}
list.add(t)
}
}
}
{code}
Since `PropertyConverter.split()` is probably be called from many other places,
this probably requires an additional argument to `split()` enable this
functionality only when called from `MapConfiguration` when that was
instantiated using `public MapConfiguration(Properties props)`
> MapConfiguration cannot handle property set to single \t or \n
> --------------------------------------------------------------
>
> Key: CONFIGURATION-613
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-613
> Project: Commons Configuration
> Issue Type: Bug
> Reporter: Maarten Boekhold
>
> See the following test, written in groovy (2.4.4). Open a groovyConsole,
> copy/paste in this code and hit ctrl-Enter to run. You need a working
> internet connection.
> {code}
> @Grab(group='commons-configuration', module='commons-configuration',
> version='1.9')
> import org.apache.commons.configuration.MapConfiguration
> import org.apache.commons.configuration.PropertiesConfiguration
> // groovy dollar-slashy-string syntax, ignores backslash
> // as an escape character so \t remains a literal string
> // backslash + t
> def propsString = $/
> prefix.field1=\t
> prefix.field2=a\tb
> /$
> // Java properties work
> Properties props = new Properties()
> props.load(new StringReader(propsString))
> // OK
> assert props.getProperty('prefix.field1') == '\t'
> // OK
> assert props.getProperty('prefix.field2') == 'a\tb'
> // PropertiesConfiguration works
> PropertiesConfiguration propscfg = new PropertiesConfiguration()
> propscfg.load(new StringReader(propsString))
> // OK
> assert propscfg.getString('prefix.field1') == '\t'
> // OK
> assert propscfg.getProperty('prefix.field2') == 'a\tb'
> // MapConfiguration does not work
> MapConfiguration mapcfg = new MapConfiguration(props)
> // OK
> assert mapcfg.getProperty('prefix.field2') == 'a\tb'
> // FAIL
> // MapConfiguration loses the single tab character
> assert mapcfg.getString('prefix.field1') == '\t'
> {code}
> Output is:
> {noformat}
> Exception thrown
> Assertion failed:
> assert mapcfg.getString('prefix.field1') == '\t'
> | | |
> | "" false
> org.apache.commons.configuration.MapConfiguration@1cd4064c
> at ConsoleScript13.run(ConsoleScript13:35)
> {noformat}
> As you can see, once we've 'converted' the java.util.Properties instance to a
> MapConfiguration, the single \t character is lost. *Embedded* tab characters
> however are retained!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
