[
https://issues.apache.org/jira/browse/MATH-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066704#comment-15066704
]
James Boyer commented on MATH-1302:
-----------------------------------
While I like the idea of offering an enumeration that depicts the convention a
user may want, a slightly simpler solution using the named constructor idiom
might be better. This way, there will be no performance sacrifice while
offering the two conventions to users.
Your comments about the conventions makes sense. Even if you do not decide to
provide multiple conventions to users, it would be beneficial to update the
documentation for the constructor Rotation(RotationOrder, double, double,
double) to mention that convention. It also might help to document the
convention in the applyTo and applyInverseTo methods.
> Rotation constructor with RotationOrder and angles produces wrong rotation
> --------------------------------------------------------------------------
>
> Key: MATH-1302
> URL: https://issues.apache.org/jira/browse/MATH-1302
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.5
> Reporter: James Boyer
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Rotation constructor taking (RotationOrder, double, double, double) has the
> local variable "composed" set to an incorrect rotation because the use of r1
> and r3 are swapped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
