Github user garydgregory commented on the pull request:
https://github.com/apache/commons-lang/pull/127#issuecomment-190350273
Hello,
Thank you for your interest in Apache Commons Lang.
Changes like this are not clean ups because it will cause an unboxing
compiler warning.
@@ -465,7 +465,7 @@ public static int toInteger(final Boolean bool, final
int trueValue, final int f
if (bool == null) {
return nullValue;
}
- return bool.booleanValue() ? trueValue : falseValue;
+ return bool ? trueValue : falseValue;
}
Would you be willing to update your patch?
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
