[ 
https://issues.apache.org/jira/browse/COMPRESS-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199214#comment-15199214
 ] 

ASF GitHub Bot commented on COMPRESS-343:
-----------------------------------------

Github user bodewig commented on the pull request:

    https://github.com/apache/commons-compress/pull/11#issuecomment-197788653
  
    I had naively assumed `InflaterInputStream#close` would free up the 
resources. Come to think of it, if we pass in the `Inflater` ourselves it makes 
sense that we are responsible for cleanup.
    
    Many thanks!
    
    I'll grep through the code to ensure the same kind of bug doesn't hit us 
anywhere else.


> Native Memory Leak in Sevenz-DeflateDecoder
> -------------------------------------------
>
>                 Key: COMPRESS-343
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-343
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.10
>            Reporter: Rene Preissel
>         Attachments: COMPRESS-343.patch
>
>
> The class ...sevenz.Coders.DeflateDecoder does not close (end()) the Deflater 
> and Inflater. This can lead to native memory issues: see 
> https://bugs.openjdk.java.net/browse/JDK-8074108.
> In our case we create a zip archive with >100000 files. The Java heap is 
> around 300MB (with 2GB max). The native memory is increasing to 8GB and 
> above. Because the Java heap has no pressure - no GC is triggered, therefore 
> the Deflaters are not collected and the native memory is not freed.  
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to