[ 
https://issues.apache.org/jira/browse/CSV-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245012#comment-15245012
 ] 

Gary Gregory edited comment on CSV-173 at 4/18/16 6:20 AM:
-----------------------------------------------------------

If we do something like the attached {{csv-rec-interface.diff}}, then it would 
make sense to go further and break BC in a 2.0 and change the usage of the 
class for the interface all over. Do we really want this? Is there an 
in-between solution? I consider the attached valid on its own but not super 
useful.


was (Author: garydgregory):
If we do something like the attached {{e:\test\csv-rec-interface.diff}}, then 
it would make sense to go further and break BC in a 2.0 and change the usage of 
the class for the interface all over. Do we really want this? Is there an 
in-between solution? I consider the attached valid on its own but not super 
useful.

> Update CSVRecord Constructor
> ----------------------------
>
>                 Key: CSV-173
>                 URL: https://issues.apache.org/jira/browse/CSV-173
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>    Affects Versions: 1.2
>            Reporter: Mike Foody
>            Priority: Minor
>         Attachments: csv-rec-interface.diff
>
>
> Thanks for the solid library. This is a simple change but the fact that 
> CSVRecord is final and doesn't have a public constructor means you end up 
> having to write more code than seems necessary just to instantiate instances 
> for test cases. If it was made non final then most mocking frameworks would 
> happily mock it or if it had a public constructor it could just be 
> instantiated. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to