Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/101#discussion_r62435581
--- Diff: src/main/java/org/apache/commons/lang3/RandomStringUtils.java ---
@@ -81,6 +81,20 @@ public static String random(final int count) {
public static String randomAscii(final int count) {
return random(count, 32, 127, false, false);
}
+
+ /**
+ * <p>Creates a random string whose length is between the minimum and
maximum.</p>
+ *
+ * <p>Characters will be chosen from the set of characters whose
+ * ASCII value is between {@code 32} and {@code 126} (inclusive).</p>
+ *
+ * @param minInclusive the minimum length of the string to generate
+ * @param maxInclusive the maximum length of the string to generate
+ * @return the random string
+ */
+ public static String randomAscii(final int minInclusive, final int
maxInclusive ) {
--- End diff --
I guess the intent would be even clearer if the parameters were called
`minLengthInclusive` and `maxLengthInclusive`. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
