[ 
https://issues.apache.org/jira/browse/CODEC-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated CODEC-220:
-----------------------
    Attachment: MessageDigestHelper.java

Sample implementation as a separate class.
This has the advantage of allowing a consistent approach for all digest 
algorithms, without needing lots of methods.

If required the code could be merged into DigestUtils.

The new methods added in 1.11 such as sha224* could be reverted in favour of 
the fluent approach.

> Possible more OO-like approach to DigestUtils
> ---------------------------------------------
>
>                 Key: CODEC-220
>                 URL: https://issues.apache.org/jira/browse/CODEC-220
>             Project: Commons Codec
>          Issue Type: Improvement
>            Reporter: Sebb
>         Attachments: MessageDigestHelper.java
>
>
> DigestUtils is starting to get a bit unwieldy with so many similar static 
> methods.
> One approach would be to use a Fluent approach (method chaining).
> e.g. DigestUtils.MDA("My-Digest").digestHex(File f);
> There would only need to be digest,digestHex and update instance methods for 
> the different input types, currently byte, ByteBuffer, InputStream, File.
> Whereas at present these are repeated for each digest type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to