[ 
https://issues.apache.org/jira/browse/BCEL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320289#comment-15320289
 ] 

ASF GitHub Bot commented on BCEL-92:
------------------------------------

GitHub user iloveeclipse opened a pull request:

    https://github.com/apache/commons-bcel/pull/5

    BCEL6 compatibility to 5.2 snapshots

    First commit: added Git ignore file
    Second commit: follow up on the BCEL6 compatibility discussion.
    
    Attempt to fix the StackMapTable misery, see BCEL-92 and BCEL-248
    Added StackMapTable/StackMapTableEntry back, basically 1:1 copy of
    StackMap/StackMapEntry.
    Added related, previously removed constants back to Constants (not they
    match those from Const).
    Updated Visitor* interfaces to handle both types.
    Updated Attaribute to create StackMapTable in case we see
    "StackMapTable" attribute.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iloveeclipse/commons-bcel apache/trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-bcel/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 5e94bac1078d98a7f36fd3e6642a71c7d0642e64
Author: Andrey Loskutov <[email protected]>
Date:   2016-06-08T06:27:45Z

    Added Git ignore file

commit ff83f03d3314fa169917a7f523937373f3dda966
Author: Andrey Loskutov <[email protected]>
Date:   2016-06-08T09:25:29Z

    Attempt to fix the StackMapTable misery, see BCEL-92 and BCEL-248
    
    Added StackMapTable/StackMapTableEntry back, basically 1:1 copy of
    StackMap/StackMapEntry.
    
    Added related, previously removed constants back to Constants (not they
    match those from Const).
    
    Updated Visitor* interfaces to handle both types.
    
    Updated Attaribute to create StackMapTable in case we see
    "StackMapTable" attribute.

----


> Properly parse StackMapTable attributes in Java 6 classfiles
> ------------------------------------------------------------
>
>                 Key: BCEL-92
>                 URL: https://issues.apache.org/jira/browse/BCEL-92
>             Project: Commons BCEL
>          Issue Type: Improvement
>          Components: Main
>    Affects Versions: unspecified
>            Reporter: Michael Martin
>            Assignee: Apache Commons Developers
>            Priority: Blocker
>             Fix For: 6.0
>
>         Attachments: StackMapTable.patch, java6stackmap.patch
>
>
> Java 6 includes a "StackMapTable" type that is used for its new split
> verification scheme.  This means many Code attributes will have StackMapTable
> attributes attached.  This format is similar but not quite identical to the
> already implemented StackMap.
> I have developed a patch that adds the necessary functionality to the 
> classfile
> parser (mostly by copy-pasting code from StackMap and StackMapEntry), and will
> attach it shortly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to