[
https://issues.apache.org/jira/browse/CRYPTO-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339122#comment-15339122
]
Dapeng Sun commented on CRYPTO-72:
----------------------------------
Thank Sebb for filing the issue, I think the issue have been fixed at
CRYPTO-76, please feel free to reopen if necessary.
CRYPTO-76: Remove log dependence
Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/4117c569
Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/4117c569
Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/4117c569
> CryptoCipherFactory.getInstance does unnecessary class instantiation
> --------------------------------------------------------------------
>
> Key: CRYPTO-72
> URL: https://issues.apache.org/jira/browse/CRYPTO-72
> Project: Commons Crypto
> Issue Type: Bug
> Reporter: Sebb
>
> The CryptoCipherFactory.getInstance method calls getCipherClasses which
> splits the string containing the class name(s) and then creates an instance
> of each (if possible) using ReflectionUtils.getClassByName.
> However the getInstance method stops processing on the first successful
> class, so any subsequent entries are not used.
> This is wasteful; the call to ReflectionUtils.getClassByName should only be
> done if it is going to be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
