[
https://issues.apache.org/jira/browse/CRYPTO-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341292#comment-15341292
]
Xianda Ke commented on CRYPTO-86:
---------------------------------
Properties instance was used only in
PositionedCryptoInputStream.getCipherState().
{code}
cipher = CryptoCipherFactory.getInstance(getCipher()
.getTransformation(), getCipher().getProperties());
{code}
agree with [~s...@apache.org]. Since PositionedCryptoInputStream itself has
Properties parameters, there is no need to hold the Properties reference in
CryptoCipher.
GitHub PR: https://github.com/apache/commons-crypto/pull/57
> What purpose does the Properties instance serve?
> ------------------------------------------------
>
> Key: CRYPTO-86
> URL: https://issues.apache.org/jira/browse/CRYPTO-86
> Project: Commons Crypto
> Issue Type: Bug
> Reporter: Sebb
>
> The CrytoCipher implementations currently store a reference to a Properties
> instance.
> However it does not appear to be used by the class except to create a new
> instance of the class.
> It looks like the field could be dropped entirely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
