[ 
https://issues.apache.org/jira/browse/CRYPTO-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343851#comment-15343851
 ] 

Xianda Ke commented on CRYPTO-82:
---------------------------------

make sense.

We can use String like "AES/CTR/NoPadding" as transformation.

move the getAlgorithmBlockSize() /getName() in CipherTransformation to 
CryptoCipher

CipherTransformation.getAlgorithmBlockSize()  -> CryptoCipher.getAlgorithm()
CipherTransformation.getName() -> CryptoCipher.getBlockSize()

The api will be similar to JCE.

> CipherTransformation is an enum which limits the possible transformations
> -------------------------------------------------------------------------
>
>                 Key: CRYPTO-82
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-82
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>
> The class CipherTransformation is an enum with only 3 entries currently.
> This seems wrong; surely there are many more possible transformations?
> An enum should generally only be used to denote a limited and known set of 
> choices. Otherwise users are limited to whatever was made available when the 
> code was released.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to