Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/171
@august782, thanks for being understanding. I think finding redundant
tests, and simplifying it is a good idea, just not in the case of tests
covering many different scenarios.
I think many tests in Apache Commons components are written with scenarios
in mind, and method-oriented. As normally the components are libraries to be
included in other systems, the tests aim at asserting that methods work as
expected, under different conditions (i.e. with a diverse range of possible
arguments).
Having good code coverage is important as well, but tests are not being
written in Apache Commons components simply to have a high score in the reports
- though normally covering well your scenarios, you end up with a good branch
and line test coverage as well (citation needed :) ).
So if you have found redundant tests, where the same scenario is being
covered in multiple tests, and you believe that reducing it will i) benefit
users and developers in understanding the code, and ii) still cover the
possible use cases for the library, or iii) make it easier to assert the same
thing, then I think these pull requests would be useful.
For other pull requests that disable or remove tests based only on line and
or branch coverage, I would still argue against removing them, and in favor to
keep them; for the reasons I stated before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
