[ 
https://issues.apache.org/jira/browse/MATH-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451537#comment-15451537
 ] 

Gilles commented on MATH-1381:
------------------------------

Having just looked at your proposed, I can't be sure that it fixes a potential 
bug in the computation.
The wrong value being so much larger than the expected 1, it seems quite 
possible that wrong results
could also be lower than 1, which your fix wouldn't fix.

At first sight, it would be useful to test a whole range of values against the 
results provided by another implementation.

> BinomialTest P-value > 1
> ------------------------
>
>                 Key: MATH-1381
>                 URL: https://issues.apache.org/jira/browse/MATH-1381
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Wang Qiang
>
> When I use the Binomial Test, I got p-value > 1 for two sided check.
> Example:
> (new BinomialTest()).binomialTest(200, 200, 0.9950429, 
> AlternativeHypothesis.TWO_SIDED) == 1.3701357550780435
> In my case, if the expected p-value is 1 (calculated by package in other 
> language, scipy in this case), the p-value returned could be > 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to