Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/186#discussion_r78293625
--- Diff: src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
---
@@ -1216,91 +1217,104 @@ public void testIsDigits() {
}
/**
- * Tests isNumber(String) and tests that createNumber(String) returns
- * a valid number iff isNumber(String) returns false.
+ * Tests isCreatable(String) and tests that createNumber(String)
returns
+ * a valid number iff isCreatable(String) returns false.
*/
@Test
- public void testIsNumber() {
- compareIsNumberWithCreateNumber("12345", true);
--- End diff --
Don't remove this tests. Although we have deprecated `isNumber` we will
probably have to maintain the code for a while before it can be dropped in Lang
4.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
