Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/189
Hi @yufcuy,
Sorry for the delay to look into this.
I looked at the first two implements this morning to refresh my memory. The
first one creating the whole comparison table, and the second one with just the
current and previous row. Both described in the Wikipedia page you linked
(thanks for that).
Then I started reviewing your pull request, and I believe your
implementation is correct :-) though I couldn't find the exact algorithm
implementation description on Wikipedia. The best I could find was this page:
http://blog.softwx.net/2014/12/optimizing-levenshtein-algorithm-in-c.html
The page mentioned above mentions the single-array approach. We could add a
link to it in the Javadoc, as for the previous two implementations. What do you
think?
There are other trivial changes regarding spelling, typos, tabs vs. spaces,
etc. So I will add a few more comments, but all tests are passing, I see no
regression (feature-wise, or in performance), and if you agree with the minor
adjustments we may have to do, then I believe we are ready to merge it.
@britter should we keep it in [lang], or in [text]? Either way, I will
replicate the change in the Levenshtein implementation in [text] :-)
Cheers
Bruno
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
