[ 
https://issues.apache.org/jira/browse/TEXT-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671333#comment-15671333
 ] 

Rob Tompkins commented on TEXT-21:
----------------------------------

I've thrown up a PR to resolve 
this...https://github.com/apache/commons-text/pull/9.

I've omitted working on "Score" and "Metric" separately, and instead am only 
drawing a distinction between "SimilarityScore" and "EditDistance" in terms of 
which of the metric axioms are satisfied. Also I moved JaroWinkler over to 
extend from SimilarityScore as opposed to EditDistance. I think that it 
sufficiently covers what we're looking for here.

> Have a clear distinction between Edit Distance, String Similarity, Score, 
> Metric, etc
> -------------------------------------------------------------------------------------
>
>                 Key: TEXT-21
>                 URL: https://issues.apache.org/jira/browse/TEXT-21
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>
> From LANG-1269.
> A user reported a nomenclature issue in [lang], which occurs in [text] as 
> well.
> Currently we have an interface called EditDistance, with the following 
> implementations:
> * CosineDistance
> * HammingDistance
> * JaroWrinklerDistance
> * and LevenshteinDistance
> JaroWrinkler is actually a similarity score, and not a distance. We have 
> other classes in the oact.similarity package too.
> * CosineSimilarity
> * FuzzyScore
> We need to provide users a clear distinction on what we call an edit 
> distance, similarity or score.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to