Douglas Stevens created DBUTILS-133:
---------------------------------------

             Summary: ON DUPLICATE KEY clause can cause NPE with 
QueryRunner.insert
                 Key: DBUTILS-133
                 URL: https://issues.apache.org/jira/browse/DBUTILS-133
             Project: Commons DbUtils
          Issue Type: Bug
    Affects Versions: 1.6
         Environment: Java 8, Mysql (mysql.mysql-connector-java.version = 
5.1.40)
            Reporter: Douglas Stevens


Using QueryRunner.insert with an ON DUPLICATE KEY clause in the query may cause 
a NullPointerException, presumably when there is no new row and therefore no 
new row id to return. Here is an example. The NPE is reported on the line with 
'id = query.insert('. Have seen other examples of the same behavior.

        long id = 0;
        try {
            QueryRunner qry = new QueryRunner(myDataSource);
            id = qry.insert(
                    "INSERT INTO VinDecodeCache (License, State, Vin, Make, 
Model, Trim, Engine, Year, "
                            + "BaseId, MakeId, ModelId, TrimId, EngineId, 
CreateDate) "
                            + "VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?) ON DUPLICATE KEY UPDATE "
                            + "Vin = ?, Make = ?, Model = ?, Trim = ?, Engine = 
?, Year = ?, "
                            + "BaseId = ?, MakeId = ?, ModelId = ?, TrimId = ?, 
EngineId = ?, CreateDate = ?",
                    new ScalarHandler<Long>(), license, state, vin, make, 
model, trim, engine, year, baseId, makeId,
                    modelId, trimId, engineId, now, vin, make, model, trim, 
engine, year, baseId, makeId, modelId,
                    trimId, engineId, new Date());
        } catch (Exception e) {
            LOG.error("Unexpected error caching vin decode data", e);
            id = 0;
        }
        return id;




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to