[
https://issues.apache.org/jira/browse/TEXT-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830432#comment-15830432
]
Bruno P. Kinoshita commented on TEXT-58:
----------------------------------------
Hi all,
Good points raised in the ticket, both regarding name and the public mutable
array.
What about the following, based on previous comments:
* Remove the methods and use static member variables
* Replace the mutable arrays by an immutable map
* And then change the methods to accept a map? (The LookupTranslator fills a
hashmap with the given lookup[][])
These arrays are convenience tables, used for look-ups. The idea is to provide
some existing tables like these for users, but also allow them to call the
methods passing their own look-up tables.
> All uppercase methods?
> ----------------------
>
> Key: TEXT-58
> URL: https://issues.apache.org/jira/browse/TEXT-58
> Project: Commons Text
> Issue Type: Improvement
> Reporter: Gilles
> Priority: Trivial
> Labels: api, convention, standard
> Fix For: 1.0
>
>
> Class {{o.a.c.text.translate.EntityArrays}} contains methods names with all
> uppercase letters (and underscores).
> I understand that they create copies of _static_ constants (although even
> that is not true since they return arrays!), but are you sure you want to
> release a new component that does not follow the usual convention?
> I understand these comes from LANG but isn't it the right time to fix the API?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
