[
https://issues.apache.org/jira/browse/COMPRESS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833932#comment-15833932
]
Stefan Bodewig commented on COMPRESS-207:
-----------------------------------------
Thanks a lot, I've added a few inline comments but am afraid I won't get
notified if you update your branch. I'm not sure what the best workflow may be
right now, to be honest.
Your changes look good but may need to get expanded beyond bzip2 and gzip. Also
I'm not sure whether block is the correct term as in the gzip case you use it
for streams.
> add notifier support for new block in BZip2CompressorInputStream
> ----------------------------------------------------------------
>
> Key: COMPRESS-207
> URL: https://issues.apache.org/jira/browse/COMPRESS-207
> Project: Commons Compress
> Issue Type: New Feature
> Components: Compressors
> Affects Versions: 1.4.1
> Reporter: Thomas Meyer
> Priority: Minor
> Labels: API, bzip
> Attachments:
> 0001-Add-notifier-support-for-new-block-in-BZip2Compresso.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch
>
>
> hi,
> attached patch enables an program to add a listener when a new bzip2
> block is detected.
> The notifier is called with:
> - xxx.newBlock(this, currBlockPosition)
> - this = the current BZip2CompressorInputStream object
> - currBlockPosition = The offset (i.e. start position) in the compressed
> input stream of the current block
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
