[
https://issues.apache.org/jira/browse/COMMONSRDF-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839771#comment-15839771
]
ASF GitHub Bot commented on COMMONSRDF-51:
------------------------------------------
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
Thanks @afs , that makes sense, `JenaGraphImpl` was indeed using
`graph.delete()`.
I have fixed in both `JenaGraphImpl` and `JenaDatasetImpl`. See comment -
do you think there is much performance gain from not splitting into pattern but
passing the original Jena Triple (safe only when there's no Literal object with
langtag) - or shall we always use the pattern?
(e.g. would Jena TDB do things like get an internal Triple row ID out of
the jena `Triple` for faster delete?)
I added tests for Dataset that reveals that statements in default graph
come back from Jena in the named graph `<urn:x-arq:DefaultGraph>` - that's a
separate bug in `JenaDatasetImpl` and the converters - we should represent that
always as `Optional.empty()` in Commons RDF land.
> RDF-1.1 specifies that language tags need to be compared using lower-case
> -------------------------------------------------------------------------
>
> Key: COMMONSRDF-51
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-51
> Project: Apache Commons RDF
> Issue Type: Bug
> Components: api
> Affects Versions: 0.3.0
> Reporter: Peter Ansell
> Assignee: Stian Soiland-Reyes
>
> The [RDF-1.1 specification states that the [value space of Literal language
> tags is
> lowercase|https://www.w3.org/TR/rdf11-concepts/#section-Graph-Literal], which
> does not conflict with the case-insensitive specification in BCP47. The
> Literal.equals and Literal.hashCode API contracts should specify that
> language tags must be compared using lowercase, even if they are otherwise
> stored and returned as upper-case by getLanguageTag. The API currently has
> incorrect language by saying "character-by-character" for language tag
> comparisons, as that implies case-sensitive comparisons are used.
> The lowercasing must also be done using a locale that is consistent (known
> example where lowercase and uppercase do not roundtrip as expected for
> US-ASCII characters is Turkish [1]), so I would recommend actually stating
> that .toLowerCase(Locale.ENGLISH) is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
