[ https://issues.apache.org/jira/browse/COMMONSRDF-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858901#comment-15858901 ]
Stian Soiland-Reyes commented on COMMONSRDF-47: ----------------------------------------------- Discussions about the RDFParser builder pattern here: https://lists.apache.org/thread.html/f2b1933c574dc24a62c67659c43f288eb88c18f5d405150f29a24c83@%3Cdev.commons.apache.org%3E > RDFSyntax should be interface, not enum > --------------------------------------- > > Key: COMMONSRDF-47 > URL: https://issues.apache.org/jira/browse/COMMONSRDF-47 > Project: Apache Commons RDF > Issue Type: Bug > Components: api > Affects Versions: 0.2.0 > Reporter: Stian Soiland-Reyes > Assignee: Stian Soiland-Reyes > Fix For: 1.0.0 > > > [~p_ansell] raises in [pull request > 25|https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85231845] > {quote} > Using enum for RDFSyntax is a bad idea unless it overrides an interface and > the interface is used in method signatures instead of the enum. There are > many other RDFSyntaxes, and enum (without implementing an interface) is only > suited to cases where the full set are known a priori. > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346)