[
https://issues.apache.org/jira/browse/VALIDATOR-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert McGuigan updated VALIDATOR-418:
--------------------------------------
Attachment: Validator-418-test.patch
In UrlValidatorTest.java, fixes incrementTestPartsIndex() to properly cycle
through all indices; and removes the test case where the scheme is the empty
string.
> UrlValidatorTest: testIsValid() does not run all tests
> ------------------------------------------------------
>
> Key: VALIDATOR-418
> URL: https://issues.apache.org/jira/browse/VALIDATOR-418
> Project: Commons Validator
> Issue Type: Bug
> Reporter: Robert McGuigan
> Priority: Minor
> Attachments: Validator-418-test.patch
>
>
> The method testIsValid() does not iterate through all possible combinations
> of scheme, authority, etc. Namely, the last element in testUrlScheme is
> skipped. This is due to a bug in incrementTestPartsIndex, which returns
> false (indicating the maximum set of indices has been reached) prematurely.
> Incidentally, the last test scheme currently present is the empty scheme "".
> This test case has been removed in the provided patch because the url string
> parser appears to assume that the scheme is nonempty. (e.g. if the scheme is
> empty, the scheme field will often be populated with the authority data).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
