[
https://issues.apache.org/jira/browse/CRYPTO-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879935#comment-15879935
]
Junjie Chen commented on CRYPTO-135:
------------------------------------
Agree with Marcelo.
We need to fix int write(ByteBuffer src) API to avoid busy loop.
> CryptoOutputStream is always blocking
> -------------------------------------
>
> Key: CRYPTO-135
> URL: https://issues.apache.org/jira/browse/CRYPTO-135
> Project: Commons Crypto
> Issue Type: Bug
> Components: Stream
> Affects Versions: 1.1.0
> Reporter: Marcelo Vanzin
>
> CRYPTO-125 described a bug where not all data written to the
> CryptoOutputStream would make it to the underlying channel if that channel
> was non-blocking.
> The fix added in that bug makes CryptoOutputStream blocking by doing a busy
> loop. This makes it a poor match (not to say unusable) for applications that
> use non-blocking channels, since it will turn non-blocking streams into
> blocking streams that waste a lot of CPU.
> Instead, CryptoOutputStream should correctly implement non-blocking semantics
> in its implementation of WritableByteChannel.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
