Github user sebbASF commented on the issue:
https://github.com/apache/commons-lang/pull/231
The new design is more flexible. So one could add Endianness for example.
[The code still does not check for duplicate values for the same key]
However I'm not sure that the chosen names fully agree with the common
usage.
For example, architecture is often used for CISC, RISC etc.
The enums need to be carefully documented so their domain is clear.
I'm not sure it makes sense to have combined methods such as isPPC64JVM()
which asserts that it is a PPC and 64bit JVM.
Also there is a usage issue: a false response may mean that the string is
unknown. Even though there only two ProcessorArch values currently, one cannot
assume that a string which is not 64 bit must therefore be 32 bit.
I wonder if it would not be simpler to just return the Processor entry.
The caller can then check the attributes in any combinations they want.
If there is no database entry, return a Process instance with enums which
indicate "Unknown".
(Attribute enums would need an extra 'Unknown' entry).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
