[
https://issues.apache.org/jira/browse/NET-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved NET-624.
----------------------
Resolution: Fixed
Fix Version/s: 3.7
Thanks, fixed (with some added tests):
URL: http://svn.apache.org/viewvc?rev=1786469&view=rev
Log:
NET-624 SubnetInfo#toCidrNotation - a wrong format subnet mask is allowed
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/util/SubnetUtils.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/SubnetUtilsTest.java
> SubnetInfo#toCidrNotation - a wrong format subnet mask is allows
> ----------------------------------------------------------------
>
> Key: NET-624
> URL: https://issues.apache.org/jira/browse/NET-624
> Project: Commons Net
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: Makoto Sakaguchi
> Fix For: 3.7
>
>
> An IPv4 subnet mask, which is also the network mask, must consist of a set of
> contiguous 1-bits followed by a block of 0-bits (i.e. 255.255.255.0), but it
> does not check.
> {code}
> /* 255.255.0.1 is 11111111.11111111.00000000.00000001 in binary */
> SubnetUtils su = new SubnetUtils("192.168.0.1", "255.255.0.1"); // expect
> error
> SubnetInfo si = su.getInfo();
> System.out.println(si.getNetmask()); // Expect error or 255.255.0.1
> 255.255.128.0
> {code}
> https://github.com/apache/commons-net/pull/13
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
